feat: 切分 metadata 访问单独 db --story=115316807 #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请在 PR 中添加类型标签，例如： |
|
请在 PR 中添加项目标签，例如： |
dellkeji
added
project/monitor
chenguo367
reviewed
Nov 29, 2023
bkmonitor/apm/constants.py
Outdated
| @@ -33,7 +33,7 @@ class VisibleEnum: | |||
|
|
|||
| GLOBAL_CONFIG_BK_BIZ_ID = 0 | |||
| # 获取需要增加事务的DB链接名 | |||
| DATABASE_CONNECTION_NAME = getattr(settings, "METADATA_DEFAULT_DATABASE_NAME", "monitor_api") | |||
| DATABASE_CONNECTION_NAME = getattr(settings, "METADATA_DEFAULT_DATABASE_NAME", "metadata") | |||
There was a problem hiding this comment.
需要确认是否所有的事务都仅有metadata库发起吗？
There was a problem hiding this comment.
因为当前key，还没有使用，调整 METADATA_DEFAULT_DATABASE_NAME =》 APM_BACKEND_DEFAULT_DATABASE_NAME
| @@ -813,6 +824,15 @@ | |||
| "PORT": GRAFANA_MYSQL_PORT or BACKEND_MYSQL_PORT, | |||
| "OPTIONS": {"charset": "utf8mb4"}, | |||
| }, | |||
| "metadata": { | |||
| "ENGINE": "django.db.backends.mysql", | |||
| "NAME": METADATA_MYSQL_NAME, | |||
There was a problem hiding this comment.
参考上面： "PORT": GRAFANA_MYSQL_PORT or BACKEND_MYSQL_PORT,
| @@ -758,7 +759,7 @@ | |||
| KAFKA_AUTO_COMMIT = True | |||
|
|
|||
| DEFAULT_AUTO_FIELD = "django.db.models.AutoField" | |||
| DATABASE_ROUTERS = ["bk_dataview.router.DBRouter"] | |||
| DATABASE_ROUTERS = ["bk_dataview.router.DBRouter", "metadata.db_router.DBRouter"] | |||
There was a problem hiding this comment.
最好判断下是否配置了METADATA_MYSQL_HOST这种变量，如果没有这个变量，可以不用append
There was a problem hiding this comment.
需要调整路由，因为backend的默认router中，需要移除 metadata的app标识
|
暂时不需要切换 DB，先关闭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.