remove nil checks from stub list iteration

There should *never* be a nil value in the stub list, so we can stop doing runtime nil checks on the stub object as we iterate.
tenderlove · Nov 9, 2015 · 0975003 · 0975003
1 parent 4cee8ca
commit 0975003
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb
@@ -1028,7 +1028,7 @@ def self.find_by_name name, *requirements
   def self.find_by_path path
     path = path.dup.freeze
     stub = stubs.find { |spec|
-      spec.contains_requirable_file? path if spec
+      spec.contains_requirable_file? path
     }
     stub && stub.to_spec
   end
@@ -1039,7 +1039,7 @@ def self.find_by_path path
 
   def self.find_inactive_by_path path
     stub = stubs.find { |s|
-      s.contains_requirable_file? path unless s.nil? || s.activated?
+      s.contains_requirable_file? path unless s.activated?
     }
     stub && stub.to_spec
   end
@@ -1051,7 +1051,7 @@ def self.find_in_unresolved path
     # TODO: do we need these?? Kill it
     specs = unresolved_deps.values.map { |dep| dep.to_specs }.flatten
 
-    specs.find_all { |spec| spec.contains_requirable_file? path if spec }
+    specs.find_all { |spec| spec.contains_requirable_file? path }
   end
 
   ##