Upgrade to Abscissa 0.1.0-pre.1 #259
Conversation
|
Note that there's some potential follow-up work to integrate some new Abscissa features:
I have omitted these changes for now to keep the upgrade as minimally invasive as possible, and would suggest following up on these after another KMS release. |
|
Looks like the build failed because Abscissa requires the latest Rust (1.35.0). @thanethomson @liamsi would it be possible to get a new Docker image published with an updated Rust? Thanks! |
tarcieri
force-pushed
the
abscissa/v0.1.0-pre.1
branch
from
bc45bbc
to
4c48980
Compare
| atomicwrites = "0.2" | ||
| byteorder = "1.2" | ||
| bytes = "0.4" | ||
| chrono = "0.4" | ||
| failure = "0.1" | ||
| failure_derive = "0.1" | ||
| gumdrop = "0.5" |
There was a problem hiding this comment.
This is only used indirectly (via [derive(Options)], right? (I could not find any sign of #[macro_use] extern crate gumdrop;)
There was a problem hiding this comment.
I've largely switched to using Rust 2018 conventions for importing macros, where instead of #[macro_use] spooky-action-at-a-distance, macros can be imported by name just like anything else.
This allows a crate like gumdrop to re-export the proc macros from gumdrop_derive so that consumers don't need both. After the 2018 edition was released, pretty much everything with a proc macro crate switched to this convention (including abscissa).
Let me double-check with @thanethomson |
|
I'm preparing another release of Abscissa, which provides the application boilerplate / framework used by Tendermint KMS: https://github.com/iqlusioninc/abscissa This commit contains what is hopefully the minimum set of changes required to upgrade to the new version. Notably it removes all TODOs about boilerplate code that could potentially be replaced by custom derive, as `abscissa_derive` now provides that functionality. It also incorporates global application state, and the application as the owner of the configuration.
tarcieri
force-pushed
the
abscissa/v0.1.0-pre.1
branch
from
4c48980
to
3b3bd7b
Compare
I'm preparing another release of Abscissa, which provides the application boilerplate / framework used by Tendermint KMS:
https://github.com/iqlusioninc/abscissa
This commit contains what is hopefully the minimum set of changes required to upgrade to the new version.
Notably it removes all TODOs about boilerplate code that could potentially be replaced by custom derive, as
abscissa_derivenow provides that functionality.It also incorporates global application state, and the application as the owner of the configuration.