-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Apply feedback of Liquidity module QA (#215)
* remove unused make scripts * upload economic simulation report (#218) * make proto-gen and proto-swagger-gen to use docker it makes proto stub generation more deterministic * return error, do not panic * refactor and rename UpdateState to make code more readable also: - add OrderDirection field to MatchResult - remove fractionalCnt since it isn't much useful * change panic message and clean if statement * update comments in CalculateSwap * remove CoinSafeSubAmount function and check for negative coin CoinSafeSubAmount is no longer used * refactor code * refactor FindOrderMatch - remove appendFlag, breakFlag and make code more readable - rename MatchResult.BatchMsg to MatchResult.SwapMsgState - remove redundant fields in MatchResult which can be accessed through underlying SwapMsgState field - MatchResult.OrderMsgIndex - MatchResult.OrderPrice * refactor TransactAndRefundSwapLiquidityPool - move duplicate code into single place - early-check errornous conditions Co-authored-by: b-harvest <38277329+dlguddus@users.noreply.github.com> Co-authored-by: Hanjun Kim <hallazzang@gmail.com>
- Loading branch information
1 parent
007913d
commit 45cacb8
Showing
8 changed files
with
168 additions
and
391 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.