-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply feedback of Liquidity module QA #215
Apply feedback of Liquidity module QA #215
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #215 +/- ##
===========================================
- Coverage 83.43% 82.84% -0.60%
===========================================
Files 20 20
Lines 2349 2215 -134
===========================================
- Hits 1960 1835 -125
Misses 209 209
+ Partials 180 171 -9
Continue to review full report at Codecov.
|
it makes proto stub generation more deterministic
also: - add OrderDirection field to MatchResult - remove fractionalCnt since it isn't much useful
CoinSafeSubAmount is no longer used
- remove appendFlag, breakFlag and make code more readable - rename MatchResult.BatchMsg to MatchResult.SwapMsgState - remove redundant fields in MatchResult which can be accessed through underlying SwapMsgState field - MatchResult.OrderMsgIndex - MatchResult.OrderPrice
- move duplicate code into single place - early-check errornous conditions
f42dd83
to
2854273
Compare
Description
Apply feedback in Notion Page, #170
TransactAndRefundSwapLiquidityPool
if than else
cases onswap.go
Add test scripts(will proceed through separate PR)Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes