Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events for Pool Reinitialize case, Fix event type for refund #238

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented May 1, 2021

Description

  • Add Event emitting missing in Pool Reinitialize situation
  • Fix Event type in Refund Depoist/Withdraw

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam self-assigned this May 1, 2021
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #238 (0759888) into develop (5ec243f) will increase coverage by 0.11%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #238      +/-   ##
===========================================
+ Coverage    82.93%   83.04%   +0.11%     
===========================================
  Files           20       20              
  Lines         2215     2230      +15     
===========================================
+ Hits          1837     1852      +15     
  Misses         208      208              
  Partials       170      170              
Impacted Files Coverage Δ
x/liquidity/keeper/liquidity_pool.go 79.24% <95.23%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec243f...0759888. Read the comment docs.

@dongsam dongsam merged commit 17276eb into tendermint:develop May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant