Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liquidity.proto #374

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Update liquidity.proto #374

merged 5 commits into from
Jun 2, 2021

Conversation

barriebyron
Copy link
Contributor

making suggested edits here in this smaller, easier-to-process PR than in #235

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

making suggested edits here in this smaller, easier-to-process PR than in #235
@barriebyron barriebyron self-assigned this May 28, 2021
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #374 (62a3830) into develop (c51e12a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #374   +/-   ##
========================================
  Coverage    83.09%   83.09%           
========================================
  Files           20       20           
  Lines         2248     2248           
========================================
  Hits          1868     1868           
  Misses         208      208           
  Partials       172      172           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51e12a...62a3830. Read the comment docs.

@hallazzang
Copy link
Contributor

hallazzang commented May 29, 2021

Thank you @barriebyron.
The generation of the corresponding *.pb.go files is needed too, do you mind if I do it for you and push to your branch?

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hallazzang makes a good point that the generation of the corresponding *.pb.go files is needed when there is a change in any of the .proto files. Since this requires development environment in your computer, we will handle this.

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of what @hallazzang says, it seems like test coverage fails. Let me pull this branch and test it out.

@jaybxyz jaybxyz added the documentation Improvements or additions to documentation label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants