-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update liquidity.proto #374
Conversation
making suggested edits here in this smaller, easier-to-process PR than in #235
Codecov Report
@@ Coverage Diff @@
## develop #374 +/- ##
========================================
Coverage 83.09% 83.09%
========================================
Files 20 20
Lines 2248 2248
========================================
Hits 1868 1868
Misses 208 208
Partials 172 172 Continue to review full report at Codecov.
|
Thank you @barriebyron. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hallazzang makes a good point that the generation of the corresponding *.pb.go files is needed when there is a change in any of the .proto
files. Since this requires development environment in your computer, we will handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On top of what @hallazzang says, it seems like test coverage fails. Let me pull this branch and test it out.
making suggested edits here in this smaller, easier-to-process PR than in #235
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes