Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOSED, see description for other PRs with edits to these docs: Liquidity Pool genesis.proto, liquidity.proto, query.proto, tx.proto #235

Closed

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Apr 27, 2021

[UPDATE]
I closed this PR because I did the work for these files in separate PRs

see also


Description

IS > genesis.proto, liquidity.proto, query.proto, tx.proto

PR description WAS > PR to get the swagger documentation QA suggestions based on the sources, continues to after #172, #188, #206, #222

The commit of this PR consists of a .proto, swagger file diff to receive reviews and suggestions comments and is not for merge purposes, so please ignore the conflicts

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (qa/swagger-proto@2322448). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8b5fd42 differs from pull request most recent head b5268fd. Consider uploading reports for the commit b5268fd to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                 @@
##             qa/swagger-proto     #235   +/-   ##
===================================================
  Coverage                    ?   82.93%           
===================================================
  Files                       ?       20           
  Lines                       ?     2215           
  Branches                    ?        0           
===================================================
  Hits                        ?     1837           
  Misses                      ?      208           
  Partials                    ?      170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2322448...b5268fd. Read the comment docs.

Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not seeing the file diffs... doing the requested comment edits. Hmmm, lmk what I need to do differently or feel free to get the changes in

@@ -0,0 +1,3891 @@
swagger: '2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see instead #356 that is based off of the develop branch
To ensure we move fast, I provided swagger.yaml edits only in #356

I did not do the swagger.yaml edits in this PR, move along, thank you

@barriebyron barriebyron marked this pull request as ready for review May 21, 2021 02:41
@barriebyron barriebyron changed the title Liquidity Pool module Swagger documentation QA (2.2.1) docs: Liquidity Pool genesis.proto, liquidity.proto, query.proto, tx.proto May 21, 2021
@jaybxyz jaybxyz added the documentation Improvements or additions to documentation label May 25, 2021
@jaybxyz jaybxyz assigned dongsam and barriebyron and unassigned barriebyron May 25, 2021
barriebyron pushed a commit that referenced this pull request May 28, 2021
making suggested edits here in this smaller, easier-to-process PR than in #235
@barriebyron barriebyron mentioned this pull request May 28, 2021
9 tasks
@barriebyron barriebyron self-requested a review June 8, 2021 18:38
@barriebyron barriebyron changed the title docs: Liquidity Pool genesis.proto, liquidity.proto, query.proto, tx.proto CLOSED, see description for other PRs with edits to these docs: Liquidity Pool genesis.proto, liquidity.proto, query.proto, tx.proto Jun 8, 2021
@barriebyron barriebyron closed this Jun 8, 2021
@barriebyron barriebyron deleted the qa/swagger-proto branch June 8, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants