Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose merkle proofs throught tendermint core rpc interface #355

Closed
ethanfrey opened this issue Jan 9, 2017 · 2 comments
Closed

Expose merkle proofs throught tendermint core rpc interface #355

ethanfrey opened this issue Jan 9, 2017 · 2 comments

Comments

@ethanfrey
Copy link
Contributor

Request from Jae:

Add rpc call to query a merkle proof given a optional block height (defaults to last commited). If this height is available, return an serialized proof, if it is not available, return an error.

Tendermint rpc must proxy to the tmsp app, which needs to support it.

Demo this functionality in a branch of merkleeyes.

Then some client test.

All work will be done in branches tmsp_proof
@ethanfrey
Copy link
Contributor Author

Hmmm.... this functionality is not even exposed in merkle.Tree... time to work on 4 repos...

@ethanfrey ethanfrey mentioned this issue Jan 9, 2017
Merged
@melekes melekes mentioned this issue Jan 10, 2017
Closed
This was referenced Jan 10, 2017
Closed
Closed
Merged
@ebuchman ebuchman added this to the 0.8.1 milestone Jan 19, 2017
@ethanfrey
Copy link
Contributor Author

This is done and merged in develop, will be release in 0.9.

Solved in #356 and #372

@ethanfrey ethanfrey mentioned this issue May 3, 2017
Closed
troian pushed a commit to akash-network/tendermint that referenced this issue Mar 11, 2023
@mergify @lasarojc
Use the right code coverage definitions (tendermint#352) (tendermint#355
6abd3bf 
)

by moving the `codecov.yml` file from .github the root folder.

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit c906604)

Co-authored-by: Lasaro <lasaro@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebuchman @ethanfrey