-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc/jsonrpc/server: merge WriteRPCResponseHTTP and WriteRPCResponseAr #5141
Conversation
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #5141 +/- ##
==========================================
+ Coverage 62.61% 62.63% +0.02%
==========================================
Files 256 256
Lines 27161 27172 +11
==========================================
+ Hits 17007 17020 +13
- Misses 8658 8664 +6
+ Partials 1496 1488 -8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. pending linting fixes
...rrayHTTP
Closes #5135
Also, wrote a test for WriteRPCResponseHTTPError and used it with correct status codes according to https://www.jsonrpc.org/historical/json-rpc-over-http.html#response-codes