abci/grpc: return async responses in order #5520
Merged
+45
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
added
T:bug
erikgrinaker
requested review from
ebuchman,
tac0turtle,
melekes and
tessr
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5520 +/- ##
==========================================
- Coverage 61.26% 61.09% -0.18%
==========================================
Files 263 263
Lines 23687 23694 +7
==========================================
- Hits 14512 14476 -36
- Misses 7703 7743 +40
- Partials 1472 1475 +3
|
melekes
reviewed
Oct 17, 2020
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
Once #5520 lands, we can re-enable gRPC ABCI protocol in the E2E testnets.
erikgrinaker
added a commit
that referenced
this pull request
Oct 20, 2020
erikgrinaker
added a commit
that referenced
this pull request
Oct 20, 2020
erikgrinaker
added a commit
that referenced
this pull request
Oct 20, 2020
Once #5520 lands, we can re-enable gRPC ABCI protocol in the E2E testnets.
erikgrinaker
added a commit
that referenced
this pull request
Oct 22, 2020
Once #5520 lands, we can re-enable gRPC ABCI protocol in the E2E testnets.
erikgrinaker
added a commit
that referenced
this pull request
Oct 22, 2020
Once #5520 lands, we can re-enable gRPC ABCI protocol in the E2E testnets.
erikgrinaker
added a commit
that referenced
this pull request
Oct 22, 2020
Once #5520 lands, we can re-enable gRPC ABCI protocol in the E2E testnets.
This was referenced Apr 22, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5439. This is really a workaround for #5519 (unless we require async implementations to return ordered responses, but that kind of defeats the purpose of having an async API).