Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privval: retry GetPubKey/SignVote/SignProposal N times before #4812

Merged
merged 7 commits into from
May 11, 2020
Merged

privval: retry GetPubKey/SignVote/SignProposal N times before #4812

merged 7 commits into from
May 11, 2020

Conversation

melekes
Copy link
Contributor

@melekes melekes commented May 11, 2020

returning an error

Closes #4707

@melekes
Release/v0.32.11 (#4709)
672eb63 
* privval: retry GetPubKey, SignVote/Proposal indefinitely

Fixes #4275
@melekes
fix build and improve error handling
36a4e82 
Closes #4707
@melekes melekes requested a review from tessr as a code owner May 11, 2020 09:05
@auto-comment
Copy link

auto-comment bot commented May 11, 2020 •
edited by melekes
Loading

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@melekes melekes added the R:minor Release: Minor label May 11, 2020
@melekes melekes added the S:automerge Automatically merge PR when requirements pass label May 11, 2020
tac0turtle
tac0turtle approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 2afae13 into master May 11, 2020
@mergify mergify bot deleted the anton/4707-privval branch May 11, 2020 13:42
@tessr tessr removed the R:minor Release: Minor label May 27, 2020
@tac0turtle tac0turtle mentioned this pull request Jun 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@tessr tessr Awaiting requested review from tessr

Assignees
No one assigned
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

privval: proposer should not miss its round if GetPubKey returns an error
3 participants
@melekes @tac0turtle @tessr