Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: add chunked rpc interface (backport #6445) #6717

Merged
merged 2 commits into from Jul 14, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 14, 2021

This is an automatic backport of pull request #6445 done by Mergify.
Cherry-pick of d913406 has failed:

On branch mergify/bp/v0.34.x/pr-6445
Your branch is up to date with 'origin/v0.34.x'.

You are currently cherry-picking commit d9134063e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   light/rpc/client.go
	modified:   rpc/client/http/http.go
	modified:   rpc/client/interface.go
	modified:   rpc/client/local/local.go
	modified:   rpc/client/mocks/client.go
	modified:   rpc/client/rpc_test.go
	modified:   rpc/core/env.go
	modified:   rpc/core/types/responses.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   light/proxy/routes.go
	both modified:   node/node.go
	both modified:   rpc/core/net.go
	both modified:   rpc/core/routes.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

closes #6706

(cherry picked from commit d913406)

# Conflicts:
#	light/proxy/routes.go
#	node/node.go
#	rpc/core/net.go
#	rpc/core/routes.go
@lgtm-com
Copy link

lgtm-com bot commented Jul 14, 2021

This pull request introduces 25 alerts when merging 79083e6 into 2c2f511 - view on LGTM.com

new alerts:

  • 23 for Expression has no effect
  • 2 for Unreachable statement

@tac0turtle tac0turtle added C:rpc Component: JSON RPC, gRPC and removed conflicts labels Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (v0.34.x@2c2f511). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             v0.34.x    #6717   +/-   ##
==========================================
  Coverage           ?   61.54%           
==========================================
  Files              ?      265           
  Lines              ?    27754           
  Branches           ?        0           
==========================================
  Hits               ?    17081           
  Misses             ?     9121           
  Partials           ?     1552           

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tac0turtle tac0turtle merged commit da9eefd into v0.34.x Jul 14, 2021
@tac0turtle tac0turtle deleted the mergify/bp/v0.34.x/pr-6445 branch July 14, 2021 09:22
@cmwaters
Copy link
Contributor

Ah we should have probably added a changelog entry. I can add one when I merge #6720

@tac0turtle
Copy link
Contributor

tac0turtle commented Jul 14, 2021

ah whoops, my bad. Thank you

iammadab referenced this pull request in dashpay/tenderdash Oct 13, 2021
* rpc: add chunked rpc interface (#6445)

(cherry picked from commit d913406)

* fix conflicts

Co-authored-by: Sam Kleinman <garen@tychoish.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
(cherry picked from commit da9eefd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:rpc Component: JSON RPC, gRPC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants