Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Preference Helper to Kotlin #15

Closed
Tenkei opened this issue Mar 21, 2019 · 4 comments
Closed

Refactor Preference Helper to Kotlin #15

Tenkei opened this issue Mar 21, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Tenkei
Copy link
Owner

Tenkei commented Mar 21, 2019

Hi, this is a first timer issue, you only have to convert PreferenceHelper class to Kotlin and optimize it using Kotlin features.

You can check here and here for step by step guide to make contribution.
@Tenkei Tenkei added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 21, 2019
@shbhmnk
Copy link
Contributor

shbhmnk commented Apr 15, 2019

@Tenkei I would like to pick this up! Looks like a good place to start.

@Tenkei
Copy link
Owner Author

Tenkei commented Apr 15, 2019

@shubh10 Great! Be sure to take a look at contribution section first. If you have any question I would be happy yo help.

Looking forward to your pull request (^^)

@shbhmnk
Copy link
Contributor

shbhmnk commented Apr 16, 2019

Hey @Tenkei, checkout #25 when you get a second.
Please let me know if you need anything different in the changes.

@Tenkei
Copy link
Owner Author

Tenkei commented Apr 17, 2019

Great Job!

@Tenkei Tenkei closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shbhmnk @Tenkei