move all arrow-datafusion into crates

Signed-off-by: Jin Mingjian <jin.phd@gmail.com>

Cargo.toml

@@ -10,6 +10,10 @@ members = [
     "crates/client",
     "crates/test_utils",
     "crates/tests_integ",
+    "crates/arrow",
+    "crates/arrow-flight",
+    "crates/datafusion",
+    "crates/parquet",
 ]
 
 [profile.release]

crates/README.md

@@ -0,0 +1 @@
+Crates arrow, arrow-flight, datafusion and parquet are modified sources from Apache Arrow and DataFusion. Based on the specificity of these crates, they are maintained by core committers. All changes to these directory should be in a dedicated commit. You can consult more infos from the core committers if you want to make changes in this directory.

arrow-datafusion/datafusion/src/logical_plan/expr.rs → crates/datafusion/src/logical_plan/expr.rs

@@ -1061,23 +1061,13 @@ pub trait Literal {
 
 impl Literal for &str {
     fn lit(&self) -> Expr {
-        //FIXME debug_assert!(self.len()<128);
-        let mut s = String::new();
-        debug_assert!(self.len()<128);
-        s.push(self.len() as u8 as char);
-        s.push_str(self);
-        Expr::Literal(ScalarValue::LargeUtf8(Some(s)))
+        Expr::Literal(ScalarValue::LargeUtf8(Some((*self).to_owned())))
     }
 }
 
 impl Literal for String {
     fn lit(&self) -> Expr {
-        //FIXME debug_assert!(self.len()<128);
-        let mut s = String::new();
-        debug_assert!(self.len()<128);
-        s.push(self.len() as u8 as char);
-        s.push_str(self);
-        Expr::Literal(ScalarValue::LargeUtf8(Some(s)))
+        Expr::Literal(ScalarValue::LargeUtf8(Some((*self).to_owned())))
     }
 }
 

arrow-datafusion/datafusion/src/physical_plan/expressions/binary.rs → crates/datafusion/src/physical_plan/expressions/binary.rs

@@ -129,9 +129,14 @@ macro_rules! compute_largeutf8_op_scalar {
             .downcast_ref::<$DT>()
             .expect("compute_op failed to downcast array");
         if let ScalarValue::LargeUtf8(Some(string_value)) = $RIGHT {
+            //FIXME debug_assert!(self.len()<128);
+            let mut s = String::new();
+            debug_assert!(string_value.len()<128);
+            s.push(string_value.len() as u8 as char);
+            s.push_str(&string_value);
             Ok(Arc::new(paste::expr! {[<$OP _utf8_scalar>]}(
                 &ll,
-                &string_value,
+                &s,
             )?))
         } else {
             Err(DataFusionError::Internal(format!(