-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: align the starlark interface #844
Comments
Agree.
Agree.
What does |
If This hasn't been implemented yet. |
Not sure whether we should support other package management or not. If yes, maybe keep install.system_packages and have different implementation below may be a good idea |
The main concern is GPU support. So far as I know, only Ubuntu has good Nvidia support for deep learning. |
I prefer to remove it. |
SGTM. |
io.mount -> runtime.mount |
Description
install.system_packages
is apt-get, should we change toinstall.apt_packages
? Also, we haveconfig.apt_source
, notconfig.system_source
.runtime.expose(envd_port, host_port)
,io.copy(src, dest)
,io.mount(src, dest)
, should we align the term?config.pip_index(mode, url, extra_url)
,config.apt_source(mode, source)
, ifmode
is not supported yet, should move this parameter to the last one instead of the first one?Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
The text was updated successfully, but these errors were encountered: