Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: align the starlark interface #844

Closed
kemingy opened this issue Sep 5, 2022 · 8 comments · Fixed by #853 or #861
Closed

refact: align the starlark interface #844

kemingy opened this issue Sep 5, 2022 · 8 comments · Fixed by #853 or #861
Assignees

Comments

@kemingy
Copy link
Member

kemingy commented Sep 5, 2022

Description

  1. the implementation of install.system_packages is apt-get, should we change to install.apt_packages? Also, we have config.apt_source, not config.system_source.
  2. runtime.expose(envd_port, host_port), io.copy(src, dest), io.mount(src, dest), should we align the term?
  3. config.pip_index(mode, url, extra_url), config.apt_source(mode, source), if mode is not supported yet, should move this parameter to the last one instead of the first one?

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@gaocegege
Copy link
Member

I totally agree.

Ref #149

/cc @Xuanwo @VoVAllen

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 5, 2022

  1. the implementation of install.system_packages is apt-get, should we change to install.apt_packages?

Agree.

2. runtime.expose(envd_port, host_port), io.copy(src, dest), io.mount(src, dest), should we align the term?

Agree.

3. config.pip_index(mode, url, extra_url), config.apt_source(mode, source), if mode is not supported yet, should move this parameter to the last one instead of the first one?

What does mode mean?

@kemingy
Copy link
Member Author

kemingy commented Sep 5, 2022

What does mode mean?

If mode=auto, envd will try to detect the location and choose the nearest mirror.

This hasn't been implemented yet.

@Zheaoli
Copy link
Member

Zheaoli commented Sep 5, 2022

the implementation of install.system_packages is apt-get, should we change to install.apt_packages? Also, we have config.apt_source, not config.system_source.

Not sure whether we should support other package management or not. If yes, maybe keep install.system_packages and have different implementation below may be a good idea

@kemingy
Copy link
Member Author

kemingy commented Sep 5, 2022

Not sure whether we should support other package management or not. If yes, maybe keep install.system_packages and have different implementation below may be a good idea

The main concern is GPU support. So far as I know, only Ubuntu has good Nvidia support for deep learning.

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 6, 2022

This hasn't been implemented yet.

I prefer to remove it.

@gaocegege
Copy link
Member

This hasn't been implemented yet.

I prefer to remove it.

SGTM.

@VoVAllen
Copy link
Member

VoVAllen commented Sep 9, 2022

io.mount -> runtime.mount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants