Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Establish SIG Go #407

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

RFC: Establish SIG Go #407

wants to merge 4 commits into from

Conversation

wamuir
Copy link

@wamuir wamuir commented Jan 5, 2022

This RFC will be open for comment until 2022-01-21.

Status Proposed
RFC # 407
Author(s) William Muir (wamuir@gmail.com)
Sponsor Mihai Maruseac (mihaimaruseac@google.com)
Updated 2022-01-05

Objective

Establish SIG Go with the objectives of fostering and facilitating community collaboration around the TensorFlow Go bindings. Community collaboration is expected to result in improvements to the usability and maintenance of the bindings.


## Quarterly Meetings

SIG Go will hold quarterly meetings via public Google Video Conference for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be enough especially during the stage of SIG formation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also any plans for gitter? other SIGs use gitter, but it kind of depends on community preferences

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be enough especially during the stage of SIG formation?

Good point. Maybe meetings should be held monthly while the SIG is forming? Lacking some other definition, I'm thinking that this should encompass completion of all SIG launch plan items in the SIG Request along with resolution to initial problems 2 and 3 (migrating bindings to new repository, restoring interoperability with go get tooling).

My hunch when drafting the charter was that, in the long-term, more frequent meetings (e.g., monthly) may be too much.

also any plans for gitter? other SIGs use gitter, but it kind of depends on community preferences

Sure, I can add. It seems that we could just deactivate the channel if it isn't used. Possibly this is referenced generally in the charter ("other third-party communication tools") as to avoid driving a future revision to the charter if preferences change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's more of ideas than suggestions :) I guess you can also discuss these topics during the first calls with the SIG

* Restoring usability of the bindings, specifically achieving interoperability
with Go tooling for module installation.
* Improving unit testing and the coverage of tests.
* Improving package documentation, including example code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also https://github.com/tensorflow/examples not sure if we should link from there or what is the best way to make things discoverable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking along the lines of testable examples here -- examples demonstrating use of the API. These are conveniently published alongside the package documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good points, these as tests, should definitely live with code. What about bigger examples more like tutorials or end-to-end examples?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should become a distinct/additional item on the list here (rfc) and corresponding Launch Plan within the SIG Request, imho. Good add. I'm not sure what the best location is.

@mihaimaruseac
Copy link
Contributor

LGTMs to me. Thank you for making this

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this!

@carrycooldude
Copy link

Really Excited for this 🤩

mihaimaruseac
mihaimaruseac previously approved these changes Jan 15, 2022
@ematejska ematejska added the RFC: Proposed RFC Design Document label Jan 24, 2022
@ematejska ematejska added this to Needs attention in RFC management via automation Jan 24, 2022
@mihaimaruseac mihaimaruseac dismissed their stale review January 31, 2022 21:20

Needs internal approval first, sorry

@thomasjo
Copy link

Any update on this SIG? I'm very keen on contributing.

Some context: I've been driving adoption of Go within my research team for the past year. We're already heavily invested in TensorFlow for the majority of our ML research, so ensuring we (and everyone else in the community) have access to maintained Go bindings is something that I personally want to invest time and effort into. I should also be able to get approval for spending some working hours on this given how important the Go bindings will be for us.

@mihaimaruseac
Copy link
Contributor

Sadly, I left TF, so I don't know how this would progress :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC: Proposed RFC Design Document
Projects
RFC management
  
Needs attention
Development

Successfully merging this pull request may close these issues.

None yet

7 participants