Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Dep of Tensorflow_io.lmdb to LSUN #468

Closed
wants to merge 1 commit into from
Closed

Added Dep of Tensorflow_io.lmdb to LSUN #468

wants to merge 1 commit into from

Conversation

ParthS007
Copy link
Contributor

Fixes #34
@rsepassi @Conchylicultor @cyfra Please review. Thanks :)

@googlebot googlebot added the cla: yes Author has signed CLA label Apr 13, 2019
@ParthS007
Copy link
Contributor Author

@tfds-copybara Can you please tell why Kokoro is failing?

@us
Copy link
Contributor

us commented Apr 14, 2019

Kokoro run test codes using different versions of TF and python. Versions earlier than TF 2.0 give errors. So Kokoro failed.
You need to check version of TF and if version greater than 2.0 you can call tf_io otherwise you need to call old structure.

@ParthS007
Copy link
Contributor Author

You need to check version of TF and if version greater than 2.0 you can call tf_io otherwise you need to call old structure.

@us How can I do it?

us
us suggested changes Apr 15, 2019
View reviewed changes
setup.py Show resolved Hide resolved
@us
Copy link
Contributor

us commented Apr 15, 2019

You can check core/tf_combat.py to compatibility tf versions.

@Conchylicultor Conchylicultor added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 25, 2019
@us
Copy link
Contributor

us commented Jul 21, 2019

@ParthS007 hey did you check it ?

@cyfra cyfra added the author:please_respond Author - please respond to the recent comments. label Feb 8, 2020
@vijayphoenix vijayphoenix mentioned this pull request Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@us us us requested changes

Assignees
No one assigned
Labels
author:please_respond Author - please respond to the recent comments. bug Something isn't working cla: yes Author has signed CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rm dep on tf.contrib.data.LMDBDataset for TF 2.0
5 participants
@ParthS007 @us @googlebot @Conchylicultor @cyfra