Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm dep on tf.contrib.data.LMDBDataset for TF 2.0 #34

Closed
rsepassi opened this issue Feb 1, 2019 · 5 comments
Closed

Rm dep on tf.contrib.data.LMDBDataset for TF 2.0 #34

rsepassi opened this issue Feb 1, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@rsepassi
Copy link
Contributor

rsepassi commented Feb 1, 2019

tf.contrib.data.LMDBDataset will not make it to TF2. It may be moving to a new repo/package. If/when that happens, we should switch to it.

Part of #31 (TF 2.0 support)

@yongtang
Copy link
Member

yongtang commented Feb 6, 2019

LMDB has been migrated to tensorflow/io (tensorflow/io#74). The PR has been merged into the master and should be available in next release soon (hopefully in a couple of weeks).

@rsepassi
Copy link
Contributor Author

rsepassi commented Feb 6, 2019

Ok, thank you @yongtang. Could you update us when it's available in the release? TFDS tries to support Python 2 and Python 3 as well as TF 1.13, nightly, and 2.0. Will we be able to use your package (i.e. will it work across that matrix)?

@ParthS007
Copy link
Contributor

@rsepassi tensorflow/io has the latest release 20 days ago and LMDBDataset is also included in the release when I looked at the source code of release.
I want to work on this Issue. Can you please assign this to me and help me to go ahead with this issue. Thanks :)

@rsepassi
Copy link
Contributor Author

Hi @ParthS007, thank you! Please see the docs here to add the dep to LSUN.

@vijayphoenix
Copy link
Contributor

vijayphoenix commented Apr 22, 2020

This issue seems to be solved by ec89c3e.
Corresponding PR #468 can also be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants