Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in the definition of _sliced_wasserstein, tensorflow_gan/python/eval/sliced_wasserstein.py #49

Open
DLPerf opened this issue Sep 2, 2021 · 0 comments

Comments

@DLPerf
Copy link

DLPerf commented Sep 2, 2021

Hello, I found a performance issue in the definition of _sliced_wasserstein, tensorflow_gan/python/eval/sliced_wasserstein.py, tf.shape(input=a)[1] will calculated repeatedly during the program execution, resulting in reduced efficiency. I think it should be created before the loop in the _sliced_wasserstein.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant