Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework on compressed file based Dataset #91

Closed
yongtang opened this issue Feb 13, 2019 · 2 comments
Closed

Rework on compressed file based Dataset #91

yongtang opened this issue Feb 13, 2019 · 2 comments
Labels
enhancement Enhancement request

Comments

@yongtang
Copy link
Member

As the number of file based Dataset is growing, code duplications start to happen. The biggest area of duplication is the compression support. There are two types of compressions:

  1. ZLIB/GZIP where you have a single compressed entry
  2. ZIP where you have multiple entries inside (e.g, npz file is essentially a ZIP).
    The compression topic itself could be complicated, like recursive compression. The goal of tensorflow-io though, is to support formats that are commonly used in machine learning community. So one level of compression is enough.

We should rework on Dataset to have a CompressedFileDataset like abstraction.

@yongtang yongtang added the enhancement Enhancement request label Mar 3, 2019
@yongtang
Copy link
Member Author

yongtang commented Mar 9, 2019

Looks like https://github.com/libarchive/libarchive could be a decent choice for compression. Had some initial success with cifar dataset. Will create a PR soon for some initial checkin.

@yongtang
Copy link
Member Author

yongtang commented May 9, 2019

Our compression and archive support has been baked in. Now any format could add compression and archive support by specify a filter.

@yongtang yongtang closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request
Projects
None yet
Development

No branches or pull requests

1 participant