Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LMDB Support #74

Merged
merged 13 commits into from
Feb 6, 2019
Merged

Add LMDB Support #74

merged 13 commits into from
Feb 6, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Feb 1, 2019 •
edited
Loading

This PR adds support for Lightning Memory-Mapped Database (LMDB). See #73 for background.

@terrytangyuan terrytangyuan changed the title [WIP] Add LMDB Support Add LMDB Support Feb 2, 2019
@terrytangyuan terrytangyuan mentioned this pull request Feb 2, 2019
Closed
yongtang
yongtang approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the PR!

We may need to start using public tensorflow api endpoints (vs. internal api from tensorflow.python....) to make sure it works for future versions. Though this is an issue not solely related to LMDB, and could be done later.

@yongtang yongtang merged commit bc1c9f8 into tensorflow:master Feb 6, 2019
@yongtang yongtang mentioned this pull request Feb 6, 2019
Closed
@terrytangyuan terrytangyuan deleted the lmdb branch February 6, 2019 01:44
@terrytangyuan
Copy link
Member Author

Yes, I agree that we should switch to use public APIs. We can do it altogether with other dataset ops in separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongtang yongtang yongtang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrytangyuan @yongtang