Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version? #414

Closed
alykhantejani opened this issue May 28, 2024 · 5 comments
Closed

New Version? #414

alykhantejani opened this issue May 28, 2024 · 5 comments
Assignees

Comments

@alykhantejani
Copy link

Hi,

I was wondering if a new version will be cut anytime soon, I see there are many changes since a year ago.

I recently hit an error:

data.shape must start with partitions.shape, got data.shape = [2,64], partitions.shape = [1]\n\t [[{{node SGD/SGD/update_21/DynamicPartition_2}}]]

Which comes from the DynamicEmbeddingOptimizer trying to partition the data. I see in master you no longer use tf. dynamic_partition and use tfra_data_flow_ops.tfra_dynamic_partition which might solve it?

@rhdong
Copy link
Member

rhdong commented May 28, 2024

Hey @alykhantejani, thank you for connecting with us. The new version should be available very soon. We noticed the dynamic_partition issue and are working on it. We will get back to you when we get a point. Many thanks!

@alykhantejani
Copy link
Author

@rhdong ok thanks, so is still an issue in master?

@MoFHeka
Copy link
Collaborator

MoFHeka commented May 28, 2024

Hi,

I was wondering if a new version will be cut anytime soon, I see there are many changes since a year ago.

I recently hit an error:

data.shape must start with partitions.shape, got data.shape = [2,64], partitions.shape = [1]\n\t [[{{node SGD/SGD/update_21/DynamicPartition_2}}]]

Which comes from the DynamicEmbeddingOptimizer trying to partition the data. I see in master you no longer use tf. dynamic_partition and use tfra_data_flow_ops.tfra_dynamic_partition which might solve it?

tfra_data_flow_ops.tfra_dynamic_partition is mostly same as tf.dynamic_partition except supporting additional input data type. So you may pass an illegal parameter into tf.dynamic_partition OP.

@alykhantejani
Copy link
Author

Ok so this probably isnt going to solve my issue. @rhdong you said you noticed the dynamic partition issue? Is this a known bug, perhaps you could shed more light on to what the problem is?

@alykhantejani
Copy link
Author

Closing as 0.7.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants