Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Small suggestion for default value of keep_checkpoint_every_n_hours #151

Closed
kootenpv opened this issue Mar 23, 2016 · 3 comments
Closed

Comments

@kootenpv
Copy link

I was not understanding the default value of 10000 (it's not obvious if I was misunderstanding it, or if it is just never going to do it)

https://github.com/tensorflow/skflow/blob/master/skflow/estimators/dnn.py#L57

I would suggest default value of 0 which means never.

@terrytangyuan
Copy link
Member

Well, 10000 is 416.67 days - nobody's going to do that so it's the same as "never". We followed this default value from TensorFlow. Maybe there's some internal stuff going on there so 0 might mean something different, e.g. trying to save it just once. Have to check in TensorFlow internally though.

@kootenpv
Copy link
Author

Ah my bad, didn't know tensorflow came up with that default. I guess it's good to stick to their default. That said, I do believe it is a confusing default. None or 0 would be clearer in my opinion. Or something more ridiculous like 10000000. But that's for tensorflow :-)

@terrytangyuan
Copy link
Member

No problem. FYI, we recently moved skflow to TF here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants