-
Notifications
You must be signed in to change notification settings - Fork 74.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python configure fails on Windows if "bash on Ubuntu on Windows" installed #11735
Comments
This is due to bazel. Please see this page in bazel website:
|
Hi @gunan , I set that.
|
@meteorcloudy could you take a look?
…On Jul 25, 2017 11:57 AM, "Changming Sun" ***@***.***> wrote:
Hi @gunan <https://github.com/gunan> ,
I set that.
This is how did I set the env vars before running bazel command
set PATH=C:\Tools\msys64\usr\bin;C:\jdk\bin;C:\python35;C:\python35\scripts;C:\bazel;%PATH%
set BAZEL_SH=C:/Tools/msys64/usr/bin/bash.exe
set JAVA_HOME=C:/jdk
set BAZEL_PYTHON=C:/python35/python.exe
set PYTHON_BIN_PATH=C:\python35\python.exe
set PYTHON_LIB_PATH=C:\python35\lib\site-packages
set BAZEL_VS=C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11735 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHlCOZviDdzGL-1cL1y36XiSCAWBO-lLks5sRa37gaJpZM4OiDt3>
.
|
@gunan No problem, I'll reply in the corresponding bazel issue. |
How about this:
|
I think the best solution would be avoiding invoking bash explicitly.
|
Hi @meteorcloudy , Do you have any future plans of this? Could you please also fix bazelbuild/bazel#2675 , which breaks http://ci.tensorflow.org/job/tf-master-win-bzl/ for a long time. |
Hi @snnn As for bazelbuild/bazel#2675, we really want to fix it, but it's not reproducible at all, so we haven't had any clue to proceed.. And which failure exactly do you think is caused by it? |
Hi @meteorcloudy http://ci.tensorflow.org/job/tf-master-win-bzl/1422/console http://ci.tensorflow.org/job/tf-master-win-bzl/1421/console They failed because the _read_dir function in third_party/py/python_configure.bzl returned an incomplete file list. Currently I've no idea why it happens so often in CI systems, but , it's not reproducible on my local computer! |
@snnn , I see, thanks for pointing it out. |
Any updates here? |
There are actually two problems mentioned here.
|
It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly. |
1 similar comment
It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly. |
We are now upgraded to bazel 0.8, which should fix the 2nd issue. |
Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
2 similar comments
Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Nagging Assignee @meteorcloudy: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
3 similar comments
Nagging Assignee @meteorcloudy: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Nagging Assignee @meteorcloudy: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Nagging Assignee @meteorcloudy: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Nagging Assignee @meteorcloudy: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Nagging Assignee @meteorcloudy: It has been 141 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Just checking again. Any updates? |
This helps avoid invoking the wrong bash binary when "Bash on Ubuntu on Windows" is installed. Fixed tensorflow#11735
So sorry for the long delay here, sent a fix for this. |
… (#19598) * python_configure.bzl: Find bash binary path through BAZEL_SH env var. This helps avoid invoking the wrong bash binary when "Bash on Ubuntu on Windows" is installed. Fixed tensorflow/tensorflow#11735 * Readability modifications.
System information
No
Windows 10, with "bash on Ubuntu on Windows" installed
source
ec808c9
3.5.3
9e62187df84ae425a5d7226b6baf1bef576f0a10
None
None
bazel --output_base C:\t clean --expunge
bazel --output_base C:\t build --features generate_pdb_file --action_env=USE_DYNAMIC_CRT=1 --action_env=NO_MSVC_WRAPPER=1 --color=no --compilation_mode fastbuild --verbose_failures --experimental_ui --copt=/Z7 --linkopt=/DEBUG:FASTLINK --copt=/DNDEBUG --host_copt=/DNDEBUG //tensorflow/tools/pip_package:build_pip_package
Describe the problem
Build tensorflow on windows with bazel may fail because "bash on Ubuntu on Windows" is installed
It may invoke the wrong "bash" for executing these commands.
Related: bazelbuild/bazel#3445
Source code / logs
The text was updated successfully, but these errors were encountered: