Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Update bazel to 0.17.1 #22449

Closed
yongtang opened this issue Sep 21, 2018 · 6 comments
Closed

[bazel] Update bazel to 0.17.1 #22449

yongtang opened this issue Sep 21, 2018 · 6 comments
Assignees

Comments

@yongtang
Copy link
Member

yongtang commented Sep 21, 2018

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
  • Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
  • TensorFlow installed from (source or binary): source
  • TensorFlow version (use command below): PR Add Apache Parquet support for TensorFlow Dataset #19461
  • Python version: 2.7.12
  • Bazel version (if compiling from source): 0.17.1/0.17.2
  • GCC/Compiler version (if compiling from source): 5.4.0 20160609
  • CUDA/cuDNN version: N/A
  • GPU model and memory: N/A
  • Exact command to reproduce: build of PR Add Apache Parquet support for TensorFlow Dataset #19461

Describe the problem

This is a placeholder for updating bazel to 0.17.1 so that PR #19461 could pass CI tests. Before bazel 0.17.1, bazel had some issues with fetching http_archive (See bazelbuild/bazel#5932). The issue has been fixed in 0.17.1.

The update of bazel 0.17.1 requires additional efforts than bumping versions in the repo (See #22281 (comment)). Pushing bleeding edge bazel immediately caused some issues before, so it is preferred to wait until a full release cycle before making the change.

At the moment, bazel 0.17.2 has been released (See bazelbuild/bazel#6164 (comment)) which is a minor release increment to 0.17.1.

/cc @gunan

Note The bazel 0.18.0 release is not far away (See bazelbuild/bazel#5963), as far as I could see. so wait until 0.18.0 is rebased, then update to 0.17.1 is also reasonable I think.

@gunan
Copy link
Contributor

gunan commented Sep 24, 2018

@av8ramit is currently updating the CI images to use bazel 0.17.

@av8ramit
Copy link

This will be done after the 1.11 release.

@yongtang
Copy link
Member Author

@gunan @av8ramit Any update with bazel 0.17.1?

@av8ramit
Copy link

@yongtang We have not made the update yet due to some incompatibilities we are still working through.

@yongtang
Copy link
Member Author

@av8ramit Thanks for the update! 👍 ❤️

@yongtang
Copy link
Member Author

yongtang commented Jan 7, 2019

Looks like bazel 0.20 has been in place for tf repo: 55bbb4c

So this issue could be closed. Thanks all for the work!

@yongtang yongtang closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants