-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bazel-0.18.0 and use try-import #22964
Conversation
Bazel-0.18.0 is due out on monday. Lets merge this in as soon as we can. Having ./configure edit the .bazelrc is causing a lot of annoyance. |
Bumping the minimum required version to the cutting edge version has caused many issues before. |
@gunan okay fair enough. In that case bazel-0.18.0 has temporarily added back reading tools/bazel.rc so I'll make a separate PR to move things back there then when 0.19.0 is out we do this change. |
The issue #22449 might be related (needs bazel |
Disable TensorFlow from downstream project until tensorflow/tensorflow#22964 is submitted @philwo @mhlopko
Disable TensorFlow from downstream project until tensorflow/tensorflow#22964 is submitted @philwo @mhlopko
@gunan @perfinion It looks like bazel 0.19.0 has been released: |
Since Bazel 0.19.0 has come out, can we try again to merge this change? |
@perfinion Is this PR going to fix TF build with Bazel 0.19.0? If so, can you try to resolve the conflicts? Thanks! |
@gunan okay to merge now? bazel 0.19 is out |
We need to upgrade Bazel to 0.18.1 on all CI machines before merging this. |
@meteorcloudy Is that upgrade only required on TensorFlow's CI machines? |
@angersson Yes, in order not to break anything, we should upgrade Bazel on all TF CI machines. |
@meteorcloudy, then this change needs to be done internally, to be able to make all the test infra changes atomicly. |
Sounds good, I can help import this change and make those upgrades! |
Nagging Assignee @case540: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Bazel-0.18.0 adds a try-import option that will non-fatally try and import a file. Use this for the configure options so that .bazelrc does not need to change. ./configure rewriting .bazelrc makes using the git repo annoying because the file is changed. The allowed bazel range is now 0.18.0-0.20.0 inclusive. The env var TF_IGNORE_MAX_BAZEL_VERSION can be set to skip the max bazel version check. Also optionally import a /.bazelrc.user file that is gitignored so user-specific options can go in there. Fixes: tensorflow#22762 Fixes: tensorflow#22906 Signed-off-by: Jason Zaman <jason@perfinion.com>
I updated this. min version is 0.18.0, max is 0.20.0. I added an env variable to skip the max bazel version check to make testing new versions easier. Looks like the the CI builds are all failing, do they need to be upgraded? |
@meteorcloudy I'll send you a change to upgrade ubuntu to the same bazel version internally. Ping me if you need help with pulling this PR in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While minimum is 0.18, I still want our dockerfiles to have 0.20 because 0.18 and 19 have some bugs
@perfinion The Bazel version on CI machines has been upgraded now, can you rebase this PR again then we can rerun the presubmit for it. ;) |
PiperOrigin-RevId: 225413451
Disable TensorFlow from downstream project until tensorflow/tensorflow#22964 is submitted @philwo @mhlopko
Bazel-0.18.0 adds a try-import option that will non-fatally try and
import a file. Use this for the configure options so that .bazelrc does
not need to change. ./configure rewriting .bazelrc makes using the git
repo annoying because the file is changed.
Also optionally import a /.bazelrc.user file that is gitignored so
user-specific options can go in there.
Fixes: #22762
Fixes: #22906
Signed-off-by: Jason Zaman jason@perfinion.com