-
Notifications
You must be signed in to change notification settings - Fork 74.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IRFFT as a CPU kernel #10127
Conversation
Can one of the admins verify this patch? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a style nit. Assuming the tests pass, LGTM. Thanks!
tensorflow/core/kernels/fft_ops.cc
Outdated
Eigen::DSizes<Eigen::DenseIndex, FFTRank + 1> startIndices; | ||
auto sizes = input.dimensions(); | ||
|
||
// Calculate the shape of full-fft temporary tensor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style nit: please end sentences in comments with periods (here and below)
https://google.github.io/styleguide/cppguide.html#Punctuation,_Spelling_and_Grammar
@tensorflow-jenkins test this please. |
Jenkins test this please. |
It seems the failure of Windows Cmake Tests is unrelated to this PR. |
Mentioned in issue #386 and #9029. TF is now supporting FFT operators. However, there still remains IRFFT as a CPU kernel unimplemented. In this PR I made up the missing part of
FFTCPU
class, and get the CPU kernel for IRFFT work.I remove the limitation of
if test.is_gpu_available(cuda_only=True):
infft_ops_test.py
, and passed all test cases bybazel test --config=opt -k //tensorflow/python/kernel_tests:fft_ops_test
.The code is linted by clang-format 3.8 using google code style.