remove SRU num_units == x.shape[-1] restriction #16404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stegben can you add a unit test that exercises the new behavior? |
ebrevdo
approved these changes
Jan 25, 2018
ebrevdo
suggested changes
Jan 25, 2018
rmlarsen
added
stat:awaiting response
|
sure! |
|
@rmlarsen plz help me trigger CI, thank you! |
rmlarsen
added
awaiting testing (then merge)
kokoro:force-run
|
@rmlarsen I fixed the test again. I've test it on my laptop so it should be OK this time |
|
@stegben Thanks! |
rmlarsen
approved these changes
Jan 29, 2018
|
@ebrevdo this is good to go, right? Could you hit approve to confirm? |
ebrevdo
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the author's response, the restriction is unnecessary. Simply add a linear transform to the input will solve the issue
#13094