Generalize MinMax monotonic optimizer #25330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshini-Gadige
added
size:M
lgeiger
added a commit
to lgeiger/tensorflow
that referenced
this pull request
Jan 30, 2019
This PR adds `Asin`, `Atan`, `Softsign` and `Softplus` to the collection of elementwise monotonic operations. This allows the arithmetic optimizer to optimize more cases. Continuation of tensorflow#25330
ezhulenev
approved these changes
Jan 30, 2019
Harshini-Gadige
added
kokoro:force-run
Harshini-Gadige
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 1, 2019
PiperOrigin-RevId: 231880254
lgeiger
added a commit
to lgeiger/tensorflow
that referenced
this pull request
Feb 1, 2019
This PR adds `Acos`, `Acosh`, `Asin`, `Atan`, `QuantizedRelu`, `QuantizedRelu6`, `QuantizedReluX`, `Softsign` and `Softplus` to the collection of elementwise monotonic operations. This allows the arithmetic optimizer to optimize more cases. Continuation of tensorflow#25330
lgeiger
added a commit
to lgeiger/tensorflow
that referenced
this pull request
Feb 1, 2019
This PR adds `Acos`, `Acosh`, `Asin`, `Atan`, `Softsign` and `Softplus` to the collection of elementwise monotonic operations. This allows the arithmetic optimizer to optimize more cases. Continuation of tensorflow#25330
|
Thanks for the fast merge! You might want to check out #25332 too, which adds support for more monotonic ops. |
lgeiger
added a commit
to lgeiger/tensorflow
that referenced
this pull request
Feb 1, 2019
This PR adds support for max pooling operations to the algorithmic optimizer for monotonic functions. This follows up on tensorflow#25330 /cc @ezhulenev
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 5, 2019
|
@ezhulenev Can you tell me the reason why this PR was reverted in 0507dba? It would be great to get feedback so I can fix it. |
|
@lgeiger it failed in https://gist.github.com/ezhulenev/0b8ab39e1533933197a61f23675e719b
Sorry didn't have time to dig into it myself, had to rollback to unblock other teams. Probably something simple. |
lgeiger
added a commit
to lgeiger/tensorflow
that referenced
this pull request
Feb 6, 2019
This PR adds support for max pooling operations to the algorithmic optimizer for monotonic functions. This follows up on tensorflow#25330 /cc @ezhulenev
|
No worries, thanks for the link. I'll take a look. |
This was referenced Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the MinMax monotonic optimizer to support
SegmentMax,UnsortedSegmentMaxandArgMaxoperations.This will improve performance of such operations after monotonic function.