Reopen: Generalize MinMax monotonic optimizer #25584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhulenev
approved these changes
Feb 7, 2019
rthadur
added
kokoro:force-run
|
#25535 has been merged and CI errors seem to be unrelated. This should be good to go now. |
Harshini-Gadige
added
ready to pull
rthadur
added
pending merge internally
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 26, 2019
…onic PiperOrigin-RevId: 235638657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the MinMax monotonic optimizer to support
SegmentMax,UnsortedSegmentMaxandArgMaxoperations.This is a rebased version of #25330 which was reverted due to #25330 (comment).
This PR surfaces a bug in the existing algorithmic optimizer which is fixed in #25535, thus #25535 should be merged prior to this.
/cc @ezhulenev