Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong container name in AddResourceInput #26428

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

ppwwyyxx
Copy link
Contributor

@ppwwyyxx ppwwyyxx commented Mar 7, 2019

When container == "", this function puts the resource in container default_container(), but sets the handle to the wrong container "".

This PR fixes the behavior.

// Originally found by Wendy Huang. fix #26454

@rthadur rthadur self-assigned this Mar 7, 2019
@rthadur rthadur requested a review from gunan March 7, 2019 21:32
@rthadur rthadur added awaiting review Pull request awaiting review size:XS CL Change Size: Extra Small labels Mar 7, 2019
@gunan gunan added the kokoro:force-run Tests on submitted change label Mar 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 8, 2019
@rthadur rthadur added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review labels Mar 8, 2019
@tensorflow-copybara tensorflow-copybara merged commit 216cfb4 into tensorflow:master Mar 8, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 8, 2019
PiperOrigin-RevId: 237491256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] wrong container setting in OpsTestBase::AddResourceInput, easily fix
6 participants