Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of typos #26550

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Fix a couple of typos #26550

merged 1 commit into from
Mar 12, 2019

Conversation

lc0
Copy link
Contributor

@lc0 lc0 commented Mar 10, 2019

Bunch of smaller typos

@lc0
Copy link
Contributor Author

lc0 commented Mar 10, 2019

Additionally, I'd like to open up a question: I've noticed, that If a user happens to install not GPU version is_gpu_available would be always saying no.

Would it make sense to add a more explicit message saying, that you see this mostly because the installation is not for GPU. I would imagine this could save some time for some of the users.

@rthadur rthadur requested review from yifeif and Harshini-Gadige and removed request for yifeif March 11, 2019 21:37
@rthadur rthadur self-assigned this Mar 11, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 11, 2019
@rthadur rthadur added awaiting review Pull request awaiting review size:S CL Change Size: Small labels Mar 11, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 11, 2019
@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review labels Mar 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 11, 2019
@tensorflow-copybara tensorflow-copybara merged commit 6f5d24b into tensorflow:master Mar 12, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Mar 12, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 12, 2019
@tensorflower-gardener
Merge pull request #26550 from lc0:gpu-improve
e6ebfc5 
PiperOrigin-RevId: 237914357
@lc0
Copy link
Contributor Author

lc0 commented Mar 16, 2019

Additionally, I'd like to open up a question: I've noticed, that If a user happens to install not GPU version is_gpu_available would be always saying no.

Would it make sense to add a more explicit message saying, that you see this mostly because the installation is not for GPU. I would imagine this could save some time for some of the users.

@yifeif what do you think about improving this message to be more explicit? ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harshini-Gadige Harshini-Gadige Harshini-Gadige approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lc0 @Harshini-Gadige @googlebot @kokoro-team @tensorflow-copybara @rthadur