Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free builtin_data when state_ == kStateInvokableAndImmutable #26582

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Free builtin_data when state_ == kStateInvokableAndImmutable #26582

merged 1 commit into from
Mar 29, 2019

Conversation

siju-samuel
Copy link
Contributor

free builtin_data when state_ == kStateInvokableAndImmutable, memleak

@siju-samuel
free builtin_data when state_ == kStateInvokableAndImmutable
aa41f70 
free builtin_data when state_ == kStateInvokableAndImmutable
@rthadur rthadur requested a review from haozha111 March 11, 2019 21:56
@rthadur rthadur self-assigned this Mar 11, 2019
@rthadur rthadur added size:XS CL Change Size: Extra Small awaiting review Pull request awaiting review labels Mar 11, 2019
@haozha111 haozha111 requested a review from jdduke March 12, 2019 03:43
jdduke
jdduke requested changes Mar 22, 2019
View reviewed changes
Copy link
Member

@jdduke jdduke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could add a test? We run these tests through msan internally, so you don't need to check anything specific, just that it runs (and won't leak).

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 23, 2019
jdduke
jdduke approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@jdduke jdduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case? If there's not one already?

@rthadur rthadur added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 29, 2019
@tensorflow-copybara tensorflow-copybara merged commit aa41f70 into tensorflow:master Mar 29, 2019
tensorflow-copybara pushed a commit that referenced this pull request Mar 29, 2019
@tensorflower-gardener
Merge pull request #26582 from siju-samuel:patch-46
c2b23d1 
PiperOrigin-RevId: 241038747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdduke jdduke jdduke approved these changes

@haozha111 haozha111 Awaiting requested review from haozha111

Assignees

@rthadur rthadur

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@siju-samuel @jdduke @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara @rthadur