Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add eager tensor support #28636

Merged
merged 2 commits into from
May 13, 2019

Conversation

karllessard
Copy link
Contributor

PR #5/5 for eager execution environment support in Java

Among other things, it adds a Output.tensor() method to retrieve the result of an operation that has been executed eagerly.

Some more optimizations are about to come in separate PRs. Still, after merging this one, it will be possible to use eager execution of TensorFlow operations in Java.

CC: @sjamesr

@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label May 12, 2019
@sjamesr sjamesr self-assigned this May 12, 2019
* <p>This is only supported in an eager execution environment.
*
* @param outputIdx index of the output of this operation
* @return output tensor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it return if the user happens to call it in a non-eager env?

Copy link
Contributor Author

@karllessard karllessard May 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See GraphOperation class in this PR, it throws an IllegalStateException error.

It's documented in the Output.tensor() method but not in this internal one, to which Output.tensor() delegates to.

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 12, 2019
@rthadur rthadur assigned rthadur and unassigned sjamesr May 12, 2019
@rthadur rthadur requested a review from sjamesr May 12, 2019 14:05
@tensorflow-copybara tensorflow-copybara merged commit 4384648 into tensorflow:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants