Make a TFLite test case run on big-endian machines #34590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a second test case in |
|
@frreiss Can you please resolve conflicts? Thanks! |
gbaned
added
stat:awaiting response
…o issue-s390-lite-2
…o issue-s390-lite-2
|
Conflicts resolved. |
tensorflowbutler
removed
the
stat:awaiting response
|
@nutsiepully Can you please take a look on this PR? Thanks! |
jdduke
approved these changes
Apr 27, 2020
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case
BasicInterpreter.ThreeStepAllocatein/tensorflow/lite/interpreter_test.ccuses an array of little-endian binary data as one of its inputs. The little-endian data prevents this test from working properly on big-endian machines.This pull request replaces the array of little-endian data with a struct, so that the embedded 32-bit fields will be in little-endian format on little-endian machines and in big-endian format on big-endian machines. After this change, the test case passes on both little-endian and big-endian machines.