Fix: Can't set None on TextVectorization layer's split parameter problem

[rushabh-v]

resolves: #36071

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[rushabh-v]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[rushabh-v]

Can someone review this PR, please?

[rushabh-v]

@tanzhenyu Thanks for the approval. I actually forgot to put self argument in the test. I have pushed one more commit. Can you review it again, please?

[rthadur]

@rushabh-v can you please check below errors

File "/testing/parameterized.py", line 284, in bound_param_test return test_method(self, *testcase_params) File "/tensorflow/python/keras/keras_parameterized.py", line 388, in decorated _v1_session_test(f, self, config, *args, **kwargs) File "/tensorflow/python/keras/keras_parameterized.py", line 405, in _v1_session_test f(test_or_class, *args, **kwargs) File "/tensorflow/python/keras/layers/preprocessing/text_vectorization_test.py", line 1214, in test_split_equals_zero_on_adapt predictions = model.predict(predict_data) File "/tensorflow/python/keras/engine/training_v1.py", line 988, in predict use_multiprocessing=use_multiprocessing) File "/tensorflow/python/keras/engine/training_arrays.py", line 707, in predict x, check_steps=True, steps_name='steps', steps=steps) File "/tensorflow/python/keras/engine/training_v1.py", line 2330, in _standardize_user_data batch_size=batch_size) File "/tensorflow/python/keras/engine/training_v1.py", line 2357, in _standardize_tensors exception_prefix='input') File "/tensorflow/python/keras/engine/training_utils.py", line 527, in standardize_input_data standardize_single_array(x, shape) for (x, shape) in zip(data, shapes) File "/tensorflow/python/keras/engine/training_utils.py", line 527, in <listcomp> standardize_single_array(x, shape) for (x, shape) in zip(data, shapes) File "/tensorflow/python/keras/engine/training_utils.py", line 452, in standardize_single_array if (x.shape is not None and len(x.shape) == 1 and AttributeError: 'str' object has no attribute 'shape'

[rushabh-v]

hey @rthadur !

I apologize to you and @mihaimaruseac for not replying to your comments. Actually I mistakenly unsubscribed from the notification of this PR. And just saw those comments today.

But I see that the errors are solved with the last commit of @mihaimaruseac

[rthadur]

@rushabh-v we still see same error , can you please check again.

[mihaimaruseac]

It seems it's an internal error only, so probably will need manual import. Don't know if I can do this this week, but I'll add it on my plate.

[rushabh-v]

Yes, the traceback says: AssertionError: Exception of type <class 'tensorflow.python.framework.errors_impl.UnimplementedError'>: Cast int32 to string is not supported [Op:Cast]

[gbaned]

@mihaimaruseac Any update on this PR? Please. Thanks!

[gbaned]

@mihaimaruseac Any update on this PR? Please. Thanks!

[gbaned]

@mihaimaruseac Any update on this PR? Please. Thanks!

[mattdangerw]

This looks pretty stale--this fix would no longer apply at head. And the underlying issue this fixes looks already closed.

I think we can probably just close this @gbaned

[gbaned]

@mattdangerw Thanks for the confirmation. Closing this PR. Thanks!