Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo changes to the input spec when RNN.unroll is True. #37275

Closed
wants to merge 1 commit into from

Conversation

k-w-w
Copy link
Contributor

@k-w-w k-w-w commented Mar 3, 2020

The changes from fc7116d that made the input spec more stringent do not apply to all unrolled recurrent layers. I'll have to revisit b/148491963 later.

PiperOrigin-RevId: 298492355
Change-Id: I442ad2a23576cae8fa2fad02a27a199f13b159c1

PiperOrigin-RevId: 298492355
Change-Id: I442ad2a23576cae8fa2fad02a27a199f13b159c1
@k-w-w k-w-w requested a review from goldiegadde March 3, 2020 20:58
@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Mar 3, 2020
mihaimaruseac
mihaimaruseac previously approved these changes Mar 3, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 3, 2020
@mihaimaruseac mihaimaruseac dismissed their stale review March 3, 2020 22:25

The base branch was changed.

@mihaimaruseac mihaimaruseac changed the base branch from master to r2.2 March 3, 2020 22:25
@goldiegadde goldiegadde added the kokoro:force-run Tests on submitted change label Mar 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 4, 2020
@k-w-w k-w-w closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants