🔧 Loosen version constraints on typing-extensions
#53250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes loosen the version constraints on `typing-extensions` to allow TensorFlow to be installed alongside packages that require `typing-extensions >= 3.10`, such as newer versions of Black and PyLint. Previously TensorFlow required a `typing-extensions` version in the `3.7.x` series. However, the newer `3.10.x` series is fully backwards-compatible with the `3.7.x` series (there are no `3.8.x` or `3.9.x` series). Therefore, these changes allow `typing-extensions` to be installed using either the `3.7.x` or `3.10.x` series. In order to ensure that any future backwards-incompatible changes in the `typing-extensions` package don't cause issues, TensorFlow's dependency on `typing-extensions` does not allow versions from the `3.11.x` series or beyond (`< 3.11`). Fixes tensorflow#51743.
mihaimaruseac
added
the
waiting for patch release
mihaimaruseac
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes loosen the version constraints on
typing-extensionsto allow TensorFlow to be installed alongside packages that requiretyping-extensions >= 3.10, such as newer versions of Black and PyLint.Previously TensorFlow required a
typing-extensionsversion in the3.7.xseries. However, the newer3.10.xseries is fully backwards-compatible with the3.7.xseries (and there are no3.8.xor3.9.xseries). Therefore, these changes allowtyping-extensionsto be installed using either the3.7.xor3.10.xseries.In order to ensure that any future backwards-incompatible changes in the
typing-extensionspackage don't cause issues, TensorFlow's dependency ontyping-extensionsdoes not allow versions from the3.11.xseries or beyond (< 3.11).