Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Enable ROCm support for the batched potrm functions for the cholesky … #55026

Conversation

rsanthanam-amd
Copy link
Contributor

…op in XLA.

For ROCm >= 4.5, this uses hipsolver and for ROCm < 4.5 this uses rocblas/rocsolver.

@google-ml-butler google-ml-butler bot added the size:L CL Change Size: Large label Mar 5, 2022
@rsanthanam-amd
Copy link
Contributor Author

/cc @chsigg @cheshire @jurahul @jlebar

@rsanthanam-amd rsanthanam-amd force-pushed the rocm_upstream_xla_hipsolver_integration branch from e76aaeb to dffa671 Compare March 5, 2022 05:54
…op in XLA.

For ROCm >= 4.5, this uses hipsolver and for ROCm < 4.5 this uses rocblas/rocsolver.
@rsanthanam-amd rsanthanam-amd force-pushed the rocm_upstream_xla_hipsolver_integration branch from f4844d2 to 2f2ef96 Compare March 5, 2022 14:25
@gbaned gbaned added the comp:gpu GPU related issues label Mar 7, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 7, 2022
@gbaned gbaned requested a review from cheshire March 7, 2022 08:02
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Mar 7, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 7, 2022
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 7, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 7, 2022
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Mar 8, 2022
copybara-service bot pushed a commit that referenced this pull request Mar 14, 2022
…_hipsolver_integration

PiperOrigin-RevId: 434454925
@akuegel
Copy link
Member

akuegel commented Mar 14, 2022

This has been merged.

@akuegel akuegel closed this Mar 14, 2022
PR Queue automation moved this from Approved by Reviewer to Closed/Rejected Mar 14, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Mar 14, 2022
@rsanthanam-amd rsanthanam-amd deleted the rocm_upstream_xla_hipsolver_integration branch March 30, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:gpu GPU related issues size:L CL Change Size: Large
Projects
No open projects
PR Queue
  
Closed/Rejected
Development

Successfully merging this pull request may close these issues.

None yet

5 participants