Refactoring tpu_api_dlsym_initializer #55413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skye could you please review this PR? |
|
Marking "ready to pull" so I can run internal tests, not actually ready for submission. |
skye
requested changes
Mar 29, 2022
gbaned
removed
awaiting review
skye
requested changes
Mar 29, 2022
skye
approved these changes
Mar 31, 2022
google-ml-butler
bot
added
kokoro:force-run
|
@sshahrokhi Can you please address Ubuntu Sanity errors? Thank you! |
|
@gbaned the build seems to fail because of a mismatch in bazel version, I guess can we run them again to see if that is resolved? |
|
@skye is out this week, @michaelbanfield could you please review this? |
michaelbanfield
approved these changes
Apr 5, 2022
google-ml-butler
bot
added
kokoro:force-run
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
PiperOrigin-RevId: 439970863
|
Seems auto-merge is not happening but the changes are merged into master now, so we can close this. Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to remove the static initializer of the TPU for JAX, which stays in the tpu_api_dlsym_initializer file. However, The functions and links in this file are needed to be called and linked in the correct places if we remove the static initializer. Therefore, we are only keeping the static initializer in this file, and have the tpu_initializer_helper file to have the rest of the functions and links. So there is no need to link this file in any place that does not need the static initializer. This PR does not change the behavior of anything, and is only refactoring functions.