Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes two minor anchor link issues. #683

Merged
merged 1 commit into from Jan 5, 2016
Merged

Fixes two minor anchor link issues. #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorflow/g3doc/how_tos/adding_an_op/index.md
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
PREREQUISITES:

* Some familiarity with C++.
* Must have [downloaded TensorFlow source](../../get_started/index.md#source),
* Must have [downloaded TensorFlow source](../../get_started/os_setup.md#installing-from-sources),
and be able to build it.

If you'd like to incorporate an operation that isn't covered by the existing
Expand Down Expand Up @@ -107,7 +107,7 @@ REGISTER_KERNEL_BUILDER(Name("ZeroOut").Device(DEVICE_CPU), ZeroOutOp);
```

Once you
[build and reinstall TensorFlow](../../get_started/os_setup.md#pip-installation), the
[build and reinstall TensorFlow](../../get_started/os_setup.md#create-the-pip-package-and-install), the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before making any of the {#anchor} changes on #660, this link originally pointed to this part of the file (which #660 maintained, using the GitHub style anchor tag), as opposed to this change which points to this part of the file several sections down. However, it looks like your change is probably going to a more relevant part of the page, as they will need to install from sources as opposed to 'easy-installing' from pip.

I'm thinking maybe this line should read

[build and reinstall TensorFlow](../../get_started/os_setup.md#installing-from-sources), the

to point to the very start of the "Installing from Sources" section as opposed to the very end of it.

Thoughts? Probably over thinking a one-line change to a doc file, but this piqued my curiosity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think create-the-pip-package-and-install is the right tag. Inside the
adding-an-op tutorial they'd already have a source install.

On Mon, Jan 4, 2016 at 9:48 PM Sam Abrahams notifications@github.com
wrote:

In tensorflow/g3doc/how_tos/adding_an_op/index.md
#683 (comment):

@@ -107,7 +107,7 @@ REGISTER_KERNEL_BUILDER(Name("ZeroOut").Device(DEVICE_CPU), ZeroOutOp);


 Once you
-[build and reinstall TensorFlow](../../get_started/os_setup.md#pip-installation), the
+[build and reinstall TensorFlow](../../get_started/os_setup.md#create-the-pip-package-and-install), the

Before making any of the {#anchor} changes on #660
#660, this link originally
pointed to this part of the file
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md#pip-installation
(which #660 #660
maintained, using the GitHub style anchor tag), as opposed to this change
which points to this part of the file
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md#create-th%0D%20e-pip-pa%0D%20ckage-and-install
several sections down. However, it looks like your change is probably going
to a more relevant part of the page, as they will need to install from
sources as opposed to 'easy-installing' from pip.

I'm thinking maybe this line should read

build and reinstall TensorFlow, the

to point to the very start of the "Installing from Sources"
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md#installing-from-sources
section as opposed to the very end of it.

Thoughts? Probably over thinking a one-line change to a doc file, but this
piqued my curiosity.

—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/pull/683/files#r48814272.

Tensorflow system can reference and use the Op when requested.

## Generate the client wrapper
Expand Down
2 changes: 1 addition & 1 deletion tensorflow/g3doc/tutorials/image_recognition/index.md
View file
Open in desktop
Expand Up @@ -108,7 +108,7 @@ unzip tensorflow/examples/label_image/data/inception_dec_2015.zip -d tensorflow/

Next, we need to compile the C++ binary that includes the code to load and run the graph.
If you've followed [the instructions to download the source installation of
TensorFlow](http://www.tensorflow.org/versions/master/get_started/os_setup.html#source)
TensorFlow](../../get_started/os_setup.md#installing-from-sources)
for your platform, you should be able to build the example by
running this command from your shell terminal:

Expand Down