Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doccomment change #2537

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Doccomment change #2537

merged 2 commits into from
Dec 11, 2019

Conversation

lina128
Copy link
Collaborator

@lina128 lina128 commented Dec 11, 2019

This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128 and @nsthorat)


tfjs-core/src/ops/image_ops.ts, line 166 at r1 (raw file):

 * @param scoreThreshold A threshold for deciding when to remove boxes based
 *     on score. Defaults to -inf, which means any score is accepted.
 * @param softNmsSigma A float represeting the sima parameter for Soft NMS.

s/sima/sigma

s/represeting/representing

@lina128
Copy link
Collaborator Author

lina128 commented Dec 11, 2019

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128 and @nsthorat)

tfjs-core/src/ops/image_ops.ts, line 166 at r1 (raw file):

 * @param scoreThreshold A threshold for deciding when to remove boxes based
 *     on score. Defaults to -inf, which means any score is accepted.
 * @param softNmsSigma A float represeting the sima parameter for Soft NMS.

s/sima/sigma

s/represeting/representing

Done

@lina128 lina128 merged commit 5f029f1 into tensorflow:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants