[WASM] Fix bug where we try to set more memory on WASM heap than malloc'd #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
dsmilkov
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Amazing find by the way!!
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a values TypedArray is passed to the WASM backend we:
However, the values buffer size could not match the size of the values array itself because values can be a view of a larger buffer (e.g. with Array.subarray()).
This makes sure we only set into the WASM heap the number of bytes we've actually malloc'd.
The unit test I wrote to catch this is now in core (as all backends need this to be true) and I verified it crashes the page without the fix.
This change is