[wasm] Modularize remaining kernels. #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lina128
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Thank you Ann!
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)
tfjs-backend-wasm/src/kernels/AddN.ts, line 29 at r1 (raw file):
function setupFunc(backend: BackendWasm): void { wasmFunc = backend.wasm.cwrap('AddN', null /* void */, [
Use symbol.
annxingyuan
commented
Jul 27, 2020
There was a problem hiding this comment.
Reviewable status:
tfjs-backend-wasm/src/kernels/AddN.ts, line 29 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
Use symbol.
Done
tafsiri
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Great!
Reviewed 60 of 61 files at r1, 1 of 1 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up remaining cases in the WASM backend where we define kernel names / inputs / attrs within the kernel rather than importing from
tfjs-core/src/kernel_names.ts. Also castskernelFuncfunctions asKernelFuncto avoid having to cast inputs / attrs before using them.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is