Move MCT component to TFX Addons #196
Conversation
hanneshapke
requested review from
casassg,
rcrowe-google and
theadactyl
as code owners
|
Thanks for the PR! 🚀 Instructions: Approve using |
|
@codesue Let's chat async what to do with https://github.com/tensorflow/model-card-toolkit/blob/master/model_card_toolkit/utils/tfx_util.py and the related tests. Are there reasons for it to stay in the MCT repo? |
|
I think it should probably stay. It is used in core and it seems to contain the connector pieces to the TFX libraries, not the component par se. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This might be good to consider as part of tensorflow/model-card-toolkit#228. I wonder if it's feasible to move functionality specific to pipelines and mlmd to the component's new home and the mlmd client library respectively but keep functions that only used tfma, tfdv, etc. If so, we could make tfx and mlmd utils available through a |
examples/model_card_generator/MLMD_Model_Card_Toolkit_Demo.ipynb
Outdated
Show resolved
Hide resolved
examples/model_card_generator/MLMD_Model_Card_Toolkit_Demo.ipynb
Outdated
Show resolved
Hide resolved
examples/model_card_generator/MLMD_Model_Card_Toolkit_Demo.ipynb
Outdated
Show resolved
Hide resolved
First draft of project proposal.
Oops, forgot to add the dependencies!
Adding a note about statistics and schema for the changed dataset.
* Create 20220513-pandas_transform.md * Delete 20220513-PandasTransform.md
Fixing broken links on PyPI page.
* Cherry pick bot to backport changes * Update RELEASE.md * validate user is release manager
* Updated module file for compatibility * Updated module file for compatibility * Update iris_module_file.py * Created Palmer Penguins example using Colaboratory * Created Pima Indians Diabetes example pipeline using Colaboratory * Created Iris example pipeline using Colaboratory * Deleted outdated file + replaced with new examples * Deleted outdated file
Commit 93fd006 didn't correctly fix the link.
* include TFX 1.8 * increase CI * switch cache key to constaint first * remove shared cache * fix exit handler * fix patch issues * reformating yapf
CODEOWNERS
Outdated
| @@ -61,6 +61,10 @@ | |||
| # PandasTransform Component | |||
| /tfx_addons/pandas_transform @rcrowe-google | |||
|
|
|||
| # PandasTransform Component | |||
| /tfx_addons/model_card_generator @codesue @hanneshapke | |||
| /eamples/model_card_generator @codesue @hanneshapke | |||
There was a problem hiding this comment.
Arg, good catch.
.gitignore
Outdated
| .vscode/* | ||
|
|
||
| # unnecessary project files |
There was a problem hiding this comment.
Consider moving this to examples/model_card_generator/.gitignore.
There was a problem hiding this comment.
Good idea! Thank you!
There was a problem hiding this comment.
Cool! Let's revert the changes to this file before merging.
.gitignore
Outdated
| .vscode/* | ||
|
|
||
| # unnecessary project files |
There was a problem hiding this comment.
Cool! Let's revert the changes to this file before merging.
|
/lgtm |
|
Approval received from @codesue! ✅ PR is approved. Missing merge command to auto-merge PR! |
|
Thank you @codesue |
|
/merge |
|
Merged with approvals from codesue and rcrowe-google - thanks for the contribution! 🎉 |
Addresses #82
CODEOWNER