Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream dependencies, consider re-doing your customizations on top of the original code instead. #9

Closed
robertbaker opened this issue Nov 16, 2020 · 1 comment

Comments

@robertbaker
Copy link
Contributor

robertbaker commented Nov 16, 2020

You changed the code-style of the original code which makes merging upstream changes a lot harder on yourself.
In one case, IMO get => TimeSpan.Milliseconds; is more readable than what you changed it to:

get
{
    return TimeSpan.Milliseconds;
}

You can refactor your modifications so you override functionality and thus you can use the upstream nuget package and make updates a lot easier for those dependencies. Git submodules can be utilized if you must have a clone of the code in your project.

@Tentacule
Copy link
Owner

External libse/tesseract projects have been replaced by their nuget packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants