-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple command line arguments and Concise nix output #50
Conversation
CI fails though: error: trait objects without an explicit `dyn` are deprecated
--> src/buf/buf.rs:1154:30
|
1154 | fn _assert_trait_object(_b: &Buf) {}
| ^^^ help: use `dyn`: `dyn Buf`
|
note: lint level defined here
--> src/lib.rs:71:9
|
71 | #![deny(warnings, missing_docs, missing_debug_implementations)]
| ^^^^^^^^
= note: #[deny(bare_trait_objects)] implied by #[deny(warnings)]
error: trait objects without an explicit `dyn` are deprecated
--> src/buf/buf_mut.rs:1167:30
|
1167 | fn _assert_trait_object(_b: &BufMut) {}
| ^^^^^^ help: use `dyn`: `dyn BufMut`
error: aborting due to 2 previous errors
error: Could not compile `bytes`. Any idea how to fix this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails though:
This change defaulting registry
to crates.io breaks the capLints
override. Let's just remove it.
I've removed it. Hope it works. However, I didn't understand why it breaks |
@trha .. addressed the feedbacks: see the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes not marked "Required" are optional. Can you also split out the localPatterns
fix to another PR and restore the old formatting for features
?
We can, but I can't think of any way that doesn't add complexity to the overlay, so let's just leave it there for now. |
You might need to update |
No. It didn't. Fixed that too. Thanks. See the latest commit! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change: Please bring back the old formatting for features
, or lines like this would be too long.
Is there any visible cue to Required changes? I dont seem to see any.. 😕
|
ah. I see. Changed to the old formatting. (We could still make it better, but it is not worth doing now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if it seems like I'm nit picking but let's keep it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements! 1170 lines fewer is huge! The next step would be adding a warning to makePackageSet
if the overlay version and the code generator version differs.
Yes. Have created the issue for that. |
Review commit by commit for better experience.
builtins.concatLists [ [a] [b] [c] ]
to[a b c]
and such.