Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

ElementId as AuthoringToolId may be unstable in Worksharing context #57

Open
cwaluga opened this issue Jun 5, 2019 · 3 comments
Open

Comments

@cwaluga
Copy link

cwaluga commented Jun 5, 2019

ElementIds may be rearranged in worksharing synchronization due to conflicting Ids. This happens quite often. See also:
https://thebuildingcoder.typepad.com/blog/2015/02/understanding-the-use-of-the-uniqueid.html

Since Bcfier has no (obvious) way to update ElementIds from IfcGuids (which would require a loop over all elements), this might break some issues in a worksharing context.

Is it possible to make Bcfier write UniqueIds into the AuthoringToolId? To make sure nothing breaks on the way back, one can first check for ElementId, then for UniqueId.

@teocomi
Copy link
Owner

teocomi commented Jun 8, 2019

Hi @cwaluga I'm not actively maintaining the project, but if you need such a change I can have a look.
Would you need BCFier to just write out UniqueIds in the AuthoringToolId field?

@cwaluga
Copy link
Author

cwaluga commented Jun 10, 2019

Hi @teocomi. Thanks for your answer.
I can do this small change myself, so no need for you to take action. I posted this here in case that someone in the future finds the time to continue this project. It is a really small change which can make component handling more stable. In case element IDs are reordered, the only chance you have to recover the authoring ids is to loop over all elements and compare IfcGuids, which is - to my knowledge - also currently not possible in BCFier.

@teocomi
Copy link
Owner

teocomi commented Jun 13, 2019

Sounds good to me! BCFier already does some looping over IFCguids, but not for what you ask, if I'm correct:

foreach (var e in visibleElems)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants