Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Full-Screen Layout Base backgroundColor Override Issue #154

Closed
3 tasks done
teogor opened this issue Oct 10, 2023 · 0 comments · Fixed by #157
Closed
3 tasks done

[Bug]: Full-Screen Layout Base backgroundColor Override Issue #154

teogor opened this issue Oct 10, 2023 · 0 comments · Fixed by #157
Assignees
Labels
@bug Something isn't working @priority-medium
Milestone

Comments

@teogor
Copy link
Owner

teogor commented Oct 10, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

The FullScreenLayoutBase component in the @Composable library currently allows users to specify a custom backgroundColor. However, it has been observed that when a custom backgroundColor is provided, it overrides the background surface color defined by MaterialTheme. This behavior may lead to unintended UI inconsistencies and may not align with user expectations.

Expected Behavior

The backgroundColor property of FullScreenLayoutBase should work as expected, allowing users to set a custom background color when needed. However, when a value of Color.Unspecified is provided for backgroundColor, it should respect the background surface color defined by MaterialTheme, ensuring a consistent UI experience.

Proposed Solution

I propose that the backgroundColor property of FullScreenLayoutBase should default to Color.Unspecified, which will ensure that it respects the background surface color defined by MaterialTheme. Users can still override it with a custom color when needed.

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@teogor teogor added @bug Something isn't working @priority-medium labels Oct 10, 2023
@teogor teogor added this to the 1.0.0-alpha04 milestone Oct 10, 2023
@teogor teogor self-assigned this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@bug Something isn't working @priority-medium
Projects
Development

Successfully merging a pull request may close this issue.

1 participant